Create a hotspot KCM for Plasma Mobile
ClosedPublic

Authored by tfella on Apr 20 2020, 6:08 PM.

Details

Summary

Implements T12895. Might include things like bluetooth and usb tethering in the future when implemented

Test Plan

Edit SSID and password, start, connect

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
mobileHotspotKcm (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25545
Build 25563: arc lint + arc unit
tfella created this revision.Apr 20 2020, 6:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 20 2020, 6:08 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tfella requested review of this revision.Apr 20 2020, 6:08 PM
tfella updated this revision to Diff 80683.Apr 20 2020, 6:55 PM

Whitespace fix

nicolasfella added inline comments.
mobile/hotspot/CMakeLists.txt
1

remove

11

KF5::Plasma shouldn't be needed

mobile/hotspot/hotspotsettings.cpp
30

Hotspot singular

mobile/hotspot/hotspotsettings.h
32

override

mobile/hotspot/package/contents/ui/main.qml
28

id is unused. check also for others

30

I'm not 100% sure the title is actually getting used

tfella updated this revision to Diff 80688.Apr 20 2020, 7:35 PM
tfella marked 6 inline comments as done.

Fixes

This comment was removed by tfella.
nicolasfella accepted this revision.Apr 20 2020, 7:43 PM
jgrulich accepted this revision.Apr 20 2020, 7:53 PM
jgrulich added inline comments.
mobile/hotspot/package/contents/ui/main.qml
40

Using adjective as an ID looks weird to me.

This revision is now accepted and ready to land.Apr 20 2020, 7:53 PM
tfella updated this revision to Diff 80714.Apr 20 2020, 9:56 PM
tfella marked an inline comment as done.

Change id

tfella updated this revision to Diff 80765.Apr 21 2020, 1:54 PM

Use network-wireless-hotspot as icon

cblack accepted this revision.Apr 21 2020, 5:38 PM
cblack added a subscriber: cblack.

UI seems fine enough.

This revision was automatically updated to reflect the committed changes.