Differential D28996

Converted to page and added heading
ClosedPublic
Actions

Authored by niccolove on Apr 19 2020, 9:08 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R115:a876b365bb22: Converted to page and added heading
Summary

Converted applet to use the new page component with PlasmoidHeadings for header and footer.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Apr 19 2020, 9:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2020, 9:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Apr 19 2020, 9:08 PM
niccolove edited the summary of this revision. (Show Details)Apr 19 2020, 9:08 PM
niccolove added reviewers: VDG, Plasma.
niccolove edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.Apr 19 2020, 9:43 PM

Great! However the footer looks a bit weird since it doesn't touch the edges:

niccolove added a comment.Apr 22 2020, 9:19 PM
In D28996#652157, @ngraham wrote:

Great! However the footer looks a bit weird since it doesn't touch the edges:

True but it's unrelated to this patch - it's system tray cutting off everything that is outside of the applet container. I want to address that in another patch

ngraham accepted this revision.Apr 22 2020, 9:28 PM

All right.

This revision is now accepted and ready to land.Apr 22 2020, 9:28 PM
Closed by commit R115:a876b365bb22: Converted to page and added heading (authored by niccolove). · Explain WhyApr 22 2020, 9:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/main.qml (392 lines)

Diff 80940

View Options

applet/contents/ui/main.qml

Loading...