Differential D28990

Port quicklaunch from KRun::run to CommandLauncherJob
ClosedPublic
Actions

Authored by dfaure on Apr 19 2020, 5:29 PM.

Details

Reviewers
drosca
davidedmundson
broulik
Commits
R114:6e196a65c389: Port quicklaunch from KRun::run to CommandLauncherJob
Test Plan

Builds, but untested.

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25480
Build 25498: arc lint + arc unit
dfaure created this revision.Apr 19 2020, 5:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2020, 5:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 19 2020, 5:29 PM
broulik added a comment.Apr 19 2020, 8:27 PM

Since it's an applet and thus run inside Plasma, do we not rather want the KNotificationJobUiDelegate?

broulik added a comment.Apr 19 2020, 8:29 PM

Also actually this should probably be refactored completely to use KServiceAction rather passing the exec to QML and then back here :)

dfaure added a comment.Apr 19 2020, 8:39 PM

Agreed about notification delegate, will do.

Does this really use KServiceAction anywhere? I don't see that. Confusing this one and D28988? [which however can't use the KServiceAction because of special support for %D and stuff]

dfaure updated this revision to Diff 80586.Apr 19 2020, 8:41 PM

Use KNotificationJobUiDelegate

broulik added a comment.Apr 20 2020, 8:53 AM

Does this really use KServiceAction anywhere?

It doesn't but it should since it also supports jump list ations. Probably needs similar treatment like I did with task manager in D28286

dfaure added a comment.Apr 22 2020, 9:13 PM

OK, that's above my head. Shall I push this or you'll rework it all?

I just want to be able to deprecated KRun::run and friends :)

broulik accepted this revision.Apr 23 2020, 9:26 AM

If you want to rework it that'll be appreciated but I can look into it since I did the pioneer porting of Task manager

This revision is now accepted and ready to land.Apr 23 2020, 9:26 AM
dfaure closed this revision.Apr 23 2020, 9:30 AM

Revision Contents
Changeset List

Diff 80586

View Options

CMakeLists.txt

Loading...
View Options

applets/quicklaunch/plugin/CMakeLists.txt

Loading...
View Options

applets/quicklaunch/plugin/quicklaunch_p.cpp

Loading...