Differential D28940

[baloo_file] Remove KAboutData from baloo_file
ClosedPublic
Actions

Authored by bruns on Apr 18 2020, 1:16 PM.

Details

Reviewers
ngraham
leszeklesner
apol
Group Reviewers
Baloo
Commits
R293:a9af3b92b03a: [baloo_file] Remove KAboutData from baloo_file
Summary

The data is obsolete, can never be shown, and may even cause failing
ASSERTs in Ki18n, as i18n is used before QCoreApplication is initialized.

Side note: baloo_file and the other helpers (baloo_file_extractor,
baloo_filemetadata_temp_extractor from baloo-widgets) should be installed
in LIBEXECDIR, as these should never called by the user.

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25417
Build 25435: arc lint + arc unit
bruns created this revision.Apr 18 2020, 1:16 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 18 2020, 1:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 18 2020, 1:16 PM
apol accepted this revision.Apr 18 2020, 4:02 PM
This revision is now accepted and ready to land.Apr 18 2020, 4:02 PM
ngraham accepted this revision.Apr 18 2020, 4:09 PM
Closed by commit R293:a9af3b92b03a: [baloo_file] Remove KAboutData from baloo_file (authored by bruns). · Explain WhyApr 18 2020, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/main.cpp (8 lines)

Diff 80465

View Options

src/file/main.cpp

Loading...