Don't offer sending non-http(s) links and sources via KDE Connect
ClosedPublic

Authored by broulik on Apr 18 2020, 11:10 AM.

Details

Summary

chrome:// and about: pages are typically local and browser-specific, and blob: pages cannot be shared altogether.

Only targetUrlPatterns but not documentUrlPatterns is set so you can still send links from your "New Tab" or history page, evne though that'll mean you could try sharing the page itself which will fail.

Test Plan

Should we include "ftp"?

  • No longer get a defunct "Open on $phone" entry for dynamic video streams behind a blob: URL
  • No longer get a defunct "Open on $device" entry for many links in browser settings. Ones that only do JS and have an empty target still get it, unfortunately.
  • Can still share links on my "New Tab" and browser history pages

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 18 2020, 11:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2020, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 18 2020, 11:10 AM
fvogt accepted this revision.Apr 18 2020, 11:32 AM

Repository R120 Plasma Workspace

How did that happen?

Should we include "ftp"?

I'd say yes, together with ftps

Ones that only do JS and have an empty target still get it, unfortunately.

That sounds weird, none of the targets match...

This revision is now accepted and ready to land.Apr 18 2020, 11:32 AM

How did that happen?

lol I have no idea

I'd say yes, together with ftps

it doesn't recognize/allow ftps, only http, https, file, and ftp, see https://developer.chrome.com/extensions/match_patterns

That sounds weird, none of the targets match...

Maybe the target filter only applies if there is a target, dunno

This revision was automatically updated to reflect the committed changes.