Differential D28917

[Media Controller] Don't set album art on tooltip anymore
ClosedPublic
Actions

Authored by broulik on Apr 17 2020, 12:30 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:38c269dc486d: [Media Controller] Don't set album art on tooltip anymore
Summary

We don't show icons on tooltips anymore.
And the System Tray config doesn't show images.

BUG: 420197
FIXED-IN: 5.19.0

Test Plan

Untested but I'm pretty sure that's the reason for the bug

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 17 2020, 12:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2020, 12:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 17 2020, 12:30 PM
ngraham added a subscriber: ngraham.Apr 17 2020, 12:35 PM

Hmm, plasmoid.icon should probably still be set so it has the right appearance in the tray; we just modified the other components to not show that same icon on the tooltip.

broulik updated this revision to Diff 80378.Apr 17 2020, 12:37 PM
  • Set default state

(It's overridden by the State below for stopped, playing, paused, but doesn't hurt to have it as fallback with the other props I guess)

ngraham accepted this revision.Apr 17 2020, 3:25 PM
This revision is now accepted and ready to land.Apr 17 2020, 3:25 PM
Closed by commit R120:38c269dc486d: [Media Controller] Don't set album art on tooltip anymore (authored by broulik). · Explain WhyApr 17 2020, 3:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80404

View Options

applets/mediacontroller/contents/ui/main.qml

Loading...