fix(kded): center action OSD on wayland
ClosedPublic

Authored by bport on Apr 17 2020, 12:23 PM.

Details

Summary

Currently on Wayland the Action OSD is not centered on the screen.

On Wayland we will center it on m_output (laptop, with fallback to primary and
then to first one).

X behavior is not changed.

BUG: 397586

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Apr 17 2020, 12:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2020, 12:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Apr 17 2020, 12:23 PM
romangg edited the summary of this revision. (Show Details)Apr 17 2020, 2:00 PM
romangg accepted this revision.Apr 17 2020, 2:03 PM

Looks good to me. Also happy @davidedmundson ?

kded/osd.cpp
36

Correct lexicographical order on push.

144

Correct grammar on push.

This revision is now accepted and ready to land.Apr 17 2020, 2:03 PM
romangg edited the summary of this revision. (Show Details)Apr 17 2020, 2:03 PM
davidedmundson added inline comments.Apr 17 2020, 2:13 PM
kded/qml/OsdSelector.qml
34

Why are we going for this instead of a binding?

Is it so X and Y remain unset on X?

davidedmundson added inline comments.Apr 17 2020, 2:17 PM
kded/qml/OsdSelector.qml
34

That was confusing, I'll rephrase.

Is it so the property "x" remains unset when running under the x windowing environment?

bport added inline comments.Apr 17 2020, 2:31 PM
kded/qml/OsdSelector.qml
34

Yes I wanted to ensure we don't change it on X
Didn't found a way to do it with a binding

davidedmundson accepted this revision.Apr 17 2020, 2:59 PM
This revision was automatically updated to reflect the committed changes.