Currently on Wayland the Action OSD is not centered on the screen.
On Wayland we will center it on m_output (laptop, with fallback to primary and
then to first one).
X behavior is not changed.
BUG: 397586
Currently on Wayland the Action OSD is not centered on the screen.
On Wayland we will center it on m_output (laptop, with fallback to primary and
then to first one).
X behavior is not changed.
BUG: 397586
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Looks good to me. Also happy @davidedmundson ?
kded/osd.cpp | ||
---|---|---|
36 | Correct lexicographical order on push. | |
144 | Correct grammar on push. |
kded/qml/OsdSelector.qml | ||
---|---|---|
34 | Why are we going for this instead of a binding? Is it so X and Y remain unset on X? |
kded/qml/OsdSelector.qml | ||
---|---|---|
34 | That was confusing, I'll rephrase. Is it so the property "x" remains unset when running under the x windowing environment? |
kded/qml/OsdSelector.qml | ||
---|---|---|
34 | Yes I wanted to ensure we don't change it on X |