Now that we can properly recolorize all the icons, maybe we should drop the State_Selected handling altogether?

Though probably qqc2 desktop style or Kirigami still relies on this, or maybe not since they can also set a proper palette

I don't understand. The palette doesn't change when a widget is selected, does it? The selected state is used by KIconLoader to decide which color to use for text color, or highlight

state == KIconLoader::SelectedState ? pal.highlightedText().color().name() : pal.windowText().color().name(),

Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior.

This patch causes another problem with all monochrome icons on the Breeze colorscheme though:

In D28908#651078, @ndavis wrote:

Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior.

This patch causes another problem with all monochrome icons on the Breeze colorscheme though:

Isn't one of them a toolbuttons with menu, not a combobox?
I don't think this patches causes that issue. Do you have
https://phabricator.kde.org/R31:66d0b0b4e3e1adc389dbd4ce1976d81860d1880d ?

In D28908#651314, @davidre wrote:

In D28908#651078, @ndavis wrote:

Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior.

This patch causes another problem with all monochrome icons on the Breeze colorscheme though:

Isn't one of them a toolbuttons with menu, not a combobox?
I don't think this patches causes that issue. Do you have
https://phabricator.kde.org/R31:66d0b0b4e3e1adc389dbd4ce1976d81860d1880d ?

You're right, it looks like this patch doesn't cause the problem. I thought it did because the problem doesn't appear until I change color schemes and I normally change color schemes when testing Breeze patches. It's also only happening to KSysGuard as far as I can tell.