However the StatDetail enum doesn't specify which enum value will get us
UDS_LOCAL_PATH (because kio_file doesn't have that). kio_desktop does,
but doesn't honour StatDetail yet. One approach is to consider it part
of Basic, the other is to add a new enum value for it.
Details
Details
- Reviewers
meven - Commits
- R241:025079be0dc4: CopyJob: when stat'ing the dest, use StatBasic.
jobtest and testtrash still pass
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- 2020_use_StatDetails
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25415 Build 25433: arc lint + arc unit
Comment Actions
I believe that's just fine but the comment could be updated :
From udsentry.h
/// A local file path if the ioslave display files sitting /// on the local filesystem (but in another hierarchy, e.g. settings:/ or remote:/) UDS_LOCAL_PATH
So the settings:/ , remote:/ should return UDS_LOCAL_PATH for KIO::StatBasic, but file:/ should not .
The code here uses UDS_LOCAL_PATH when present only and does not require it.
Comment Actions
That's for sure, it's redundant for kio_file.
The code here uses UDS_LOCAL_PATH when present only and does not require it
Of course. Remote ioslaves can't even set it ;)
I have adjusted the comment to avoid sounding like it's required.
Comment Actions
@dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213.
After fixing, maybe we should get a test for that use case?
Comment Actions
I see the issue, because we don't resolve the symlink here, we don't figure out dest is a folder and hence copyjob acts as if moving file to dest file, instead of to dest dir.