Differential D28848

Port kontact plugin loading to KPluginLoader
ClosedPublic
Actions

Authored by dfaure on Apr 15 2020, 7:35 AM.

Details

Reviewers
mlaurent
ervin
Commits
R209:0e4d39257c68: Port kontact plugin loading to KPluginLoader
Summary

Now that all kontact plugins are in plugins/kontact5 and embed JSON metadata,
we can load them directly without the indirection of .desktop files.
This depends on D28765 (in kcmutils) though, otherwise opening the configuration dialog crashes.

For zanshin this depends on D28847. Older versions of zanshin will no longer appear
in kontact once this commit lands (but new zanshin with old kontact will still work).

Test Plan

Starting kontact, using the configure dialog (and enabling/disabling components)

Diff Detail

Repository
R209 Kontact
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Apr 15 2020, 7:35 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 15 2020, 7:35 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure requested review of this revision.Apr 15 2020, 7:35 AM
mlaurent added a comment.Apr 16 2020, 6:54 PM

So it seems that this patch can't be push until 5.70.

mlaurent added a comment.May 10 2020, 10:57 AM

it seems that now it can be commited.

This revision was not accepted when it landed; it landed in state Needs Review.May 10 2020, 12:02 PM
Closed by commit R209:0e4d39257c68: Port kontact plugin loading to KPluginLoader (authored by dfaure). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mainwindow.cpp (35 lines)

Diff 82431

View Options

src/mainwindow.cpp

Loading...