KOrganizer: port from KRun::runCommand to KIO::CommandLauncherJob
ClosedPublic
Actions

Authored by dfaure on Apr 14 2020, 11:24 PM.

Details

Reviewers

mlaurent
winterz

Commits

Summary

Requires KF5 master, let me know if I should wait until landing

Test Plan

Enabled Scheduling toolbar to start kaddressbook;
Went to the configuration dialog, custom pages, a button starts Qt designer.

Repository

R210 KOrganizer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dfaure requested review of this revision.Apr 14 2020, 11:24 PM

Perhaps you can add #ifdef version < 5.70 ...
Not sure that user will be happy if we change today to 5.70.
Regards

set KF5_VERSION to 5.69.50 in the frameworks library and require that version in korganizer?

In D28846#648892, @winterz wrote:

set KF5_VERSION to 5.69.50 in the frameworks library and require that version in korganizer?

it's the same problem as required new version.
Better is adding #ifdef :)

I'll just wait 3 more weeks before landing this, there's no rush. Once 5.70 is released it's fine to depend on it, right?

Ok I increase KF5 when it release so it will not a problem.
Regards

You can commit this one too :)

It helps if they are approved first, then they are marked as "ready to land" :)

This revision was not accepted when it landed; it landed in state Needs Review.May 10 2020, 3:25 PM

This revision was automatically updated to reflect the committed changes.

Oh I thought that I accepted it :)

			Path	Packages
M			src/calendarview.cpp (8 lines)
M			src/kcmdesignerfields.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80167	963f6f3		Apr 14 2020, 11:24 PM	★	★
Diff 2	82448	3924472	R210:1be2fb7e37144ba8896b8b2b24a298c3c33e0860	May 10 2020, 3:25 PM	★	★