Add device icons to KDE Connect context menu
ClosedPublic

Authored by broulik on Apr 14 2020, 7:21 PM.

Details

Summary

Firefox supports setting icons on menus [1]. Chrome refuses to create a menu with unknown keys, so this is guarded by IS_FIREFOX.
This uses the appropriate Breeze icons, except "computer-tablet" which I edited to have larger padding to somewhat fit better with the rest of the icons.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus#Icons

Test Plan

Probably some ESR testing? Though it said something about Firefox 55, so I suspect that has been in there since.

(Will add the "Share..." icon once D28707 is in)

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 14 2020, 7:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 14 2020, 7:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 14 2020, 7:21 PM
ndavis accepted this revision.Apr 15 2020, 3:04 AM
This revision is now accepted and ready to land.Apr 15 2020, 3:04 AM
This revision was automatically updated to reflect the committed changes.