Details
Details
- Reviewers
dfaure - Commits
- R958:8418d33a85b9: Update lxr website to follow KDE main theme
This is not tested, it is possible that it doesn't work at all. @dfaure would be grateful if you could test this patch and send me some screenshots of the result so that I can see if it looks like I imagined.
I tried installing lxr but I couldn't find glimpse search engine in my distro package.
Diff Detail
Diff Detail
- Repository
- R958 KDE Quality Website
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The font for the links at the top is too small, this is the most important part of the site for navigation.
The branch group selector doesn't show up at all.
Comment Actions
- Import bootstrap javascript to display dropdown
- Fix navbar size
- Fix issue in dark them
Comment Actions
Looks good to me. I left the patch on the website, you can test it in real life before landing the commit.
Comment Actions
I would like to ask to have the in the result tables all colums besides the "Line" ones to be left aligned. That would help scanning the results, due to similar code/paths being aligned IMHO.
See e.g. https://lxr.kde.org/search?_filestring=&_string=AUTOUIC or https://lxr.kde.org/ident?_i=KDirWatch
Comment Actions
- change a few colors
- fix alignment in the tables in search result
This was caused by the <pre> element
Comment Actions
Thanks, I like this over the previous alignments.
Two more nitpicks left for some other occasion (already noted in irc discussion):
a) with the General search, the code snippets in the "Text" column ideally might be more vertically centered, looks a bit off compared to text in other cells in same row, also due to different top/bottom spacing (perfect would be same baseline height, but I expect this will be hard to ensure)
b) font sizes are very big, one has to scroll the page a lot on my 1366x768 screen on my x220 laptop, using recent Firefox