Differential D28821

[Notifier] Port from KRun::runCommand
ClosedPublic
Actions

Authored by broulik on Apr 14 2020, 1:17 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R134:53375168eb03: [Notifier] Port from KRun::runCommand
Summary

Use ApplicationLauncherJob for launching the main application and CommandLauncherJob for launching the updater.
This also gives us a nice startup feedback for both cases now.
The KService::serviceByDesktopName could in theory return null but imho that would be severely broken if we have the updater running but rest of Discover is absent.

Test Plan
  • "Show Discover" opens discover "recommendations"
  • "View updates" opens update view

Both with a discover bouncy cursor

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 14 2020, 1:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 14 2020, 1:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 14 2020, 1:17 PM
apol accepted this revision.Apr 14 2020, 1:46 PM
apol added a subscriber: apol.

Thanks!

This revision is now accepted and ready to land.Apr 14 2020, 1:46 PM
Closed by commit R134:53375168eb03: [Notifier] Port from KRun::runCommand (authored by broulik). · Explain WhyApr 14 2020, 1:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mnotifier/CMakeLists.txt (2 lines)
Mnotifier/DiscoverNotifier.cpp (27 lines)

Diff 80101

View Options

notifier/CMakeLists.txt

Loading...
View Options

notifier/DiscoverNotifier.cpp

Loading...