Large:
Small (NoScript):
Small with js enabled:
Details
Details
Diff Detail
Diff Detail
- Repository
- R264 KApiDox
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I really dislike how you close brackets in css : it's more dense and harder to read.
You indent sometimes with 1,2 or 3 spaces: it should be consistent.
Is it something common to have css declaration within others? It's the first time I see that, so I'm confused.
Comment Actions
The css code is generated from the new scss file. I didn't remove the generated CSS code because I didn't want to add sass as a dependency of kapidox. I will add this information to the doc.
The command to generate the css code is:
sass src/kapidox/data/htmlresource/css/kapidox.scss src/kapidox/data/htmlresource/css/kapidox.css
Maybe this file can be moved later to websites/aether-sass so that the layout with the sidebar can be shared with websites/aether-sphinx and websites/aether-mediawiki and hosted in the KDE cdn.
Comment Actions
POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase
Comment Actions
OK it's clearer:
Please add somewhere that it's a generated css so that no-one tries to change it by hand and ship it
Comment Actions
I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it.
@ochurlaud should I create a sysadmin request for you to get access to the repo in invent so that you can edit it if you need?
Comment Actions
No need, I don't work much anymore on apidox.
Does it work locally? If I use your patch and try locally on my computer? If it works, then you can ship it.