I recall we originally didn't do it when Noah added these icons as browserAction.setIcon wasn't able to override the icon or something like this? However, it doesn't appear to be the case anymore in more recent versions.
While the setIcons API doesn't support theme icons, only set the custom icon when the extension fails to start.
So let's not jeopardize the normal user experience by this edge case.
Details
Details
- Reviewers
fvogt ognarb ndavis - Group Reviewers
Plasma - Commits
- R856:269da15cf9b4: Provide light icon for dark mode via theme_icons
Tool bar icon is now readable in dark mode
Chrome just ignores the key
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
For reference this is the bug report in firefox for adding js scripting: https://bugzilla.mozilla.org/show_bug.cgi?id=1416871