Provide light icon for dark mode via theme_icons
ClosedPublic

Authored by broulik on Apr 13 2020, 7:15 PM.

Details

Summary

I recall we originally didn't do it when Noah added these icons as browserAction.setIcon wasn't able to override the icon or something like this? However, it doesn't appear to be the case anymore in more recent versions.
While the setIcons API doesn't support theme icons, only set the custom icon when the extension fails to start.
So let's not jeopardize the normal user experience by this edge case.

Test Plan

Tool bar icon is now readable in dark mode

Chrome just ignores the key

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 13 2020, 7:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 13 2020, 7:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 13 2020, 7:15 PM
ognarb accepted this revision.Apr 13 2020, 7:23 PM

For reference this is the bug report in firefox for adding js scripting: https://bugzilla.mozilla.org/show_bug.cgi?id=1416871

This revision is now accepted and ready to land.Apr 13 2020, 7:23 PM
This revision was automatically updated to reflect the committed changes.