Add standard shortcut for "Show/Hide Hidden Files"
ClosedPublic

Authored by ngraham on Apr 13 2020, 6:30 PM.

Details

Summary

Add a standard shortcut for this action so it can be synchronized between different apps
and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551.

The action in Dolphin also has F8 bound to this, but the definition here only accept two
default shortcuts, and F8 seems kind of random.

CCBUG: 262551

Test Plan

Apply D28803 to KIO and D28804 to Dolphin and test there

Diff Detail

Repository
R237 KConfig
Branch
add-show-hide-hidden-files-shortcut (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25176
Build 25194: arc lint + arc unit
ngraham created this revision.Apr 13 2020, 6:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 13 2020, 6:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 13 2020, 6:30 PM
ngraham edited the test plan for this revision. (Show Details)Apr 13 2020, 6:32 PM
dfaure accepted this revision.Apr 13 2020, 7:52 PM
This revision is now accepted and ready to land.Apr 13 2020, 7:52 PM
This revision was automatically updated to reflect the committed changes.

and F8 seems kind of random.

I was asking myself why F8 was chosen and yes, it looks like it was totally random: https://github.com/KDE/kdelibs/commit/8e26f7410a9280b504d97cdfbe5d3568cfa7b9d4

Does it make sense to also create a standard action in kconfigwidgets?

I pondered that myself but every app needs to implement its own behavior, and we're not even consistent about making this a toggle action vs two separate actions.

That alone is probably a good reason to make a standard action, though.