Differential D287

Use walkBucketChain to simplify deleteItem implementation
ClosedPublic
Actions

Authored by olivierjg on Aug 28 2015, 8:38 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
olivierjg updated this revision to Diff 635.Aug 28 2015, 8:38 PM
olivierjg retitled this revision from to Use walkBucketChain to simplify deleteItem implementation.
olivierjg updated this object.
olivierjg edited the test plan for this revision. (Show Details)
olivierjg added a reviewer: KDevelop.
olivierjg set the repository for this revision to R33 KDevPlatform.
olivierjg added a project: KDevelop.
olivierjg added a subscriber: KDevelop.
olivierjg updated this revision to Diff 669.Aug 30 2015, 6:04 PM

Add test to verify current behavior

olivierjg updated this revision to Diff 927.Sep 27 2015, 7:51 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 27 2015, 7:51 AM
mwolff added a subscriber: mwolff.Sep 27 2015, 6:36 PM

lgtm in principle!

serialization/tests/test_itemrepository.cpp
251 ↗(On Diff #669)

feel free to add a friend class TestItemRepository or similar.

mwolff accepted this revision.Oct 8 2015, 10:10 AM
mwolff added a reviewer: mwolff.

consider using friend for the test case to simplify the code

This revision is now accepted and ready to land.Oct 8 2015, 10:10 AM
olivierjg closed this revision.Nov 3 2015, 8:47 PM

Already submitted.

Revision Contents
Changeset List

Diff 927

View Options

serialization/itemrepository.h

Loading...
View Options

serialization/tests/test_itemrepository.cpp

Loading...