Support for setting compression method was implemented. The setting is
available in the Compression collapsible group.
Details
Details
- Reviewers
elvisangelaccio - Commits
- R36:ae73797768a5: Support for setting compression method
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
What about createdialogtest? Does it make sense to check whether the new widget is enabled/disabled?
autotests/kerfuffle/addtoarchivetest.cpp | ||
---|---|---|
70 | This file has only empty lines as changes. | |
kerfuffle/cliinterface.cpp | ||
1047–1074 | What about making this method virtual? This way each plugin could implement it and provide whatever switch they prefer. |
Comment Actions
Another thing that I forgot: do we really want to allow the "copy" method (=no compression)? What would be the point?
Comment Actions
The Copy method of cli7z is the same as store method in clizip. It can be used to combine several files into one i.e. like an uncompressed tar archive, so I don't think we should remove it.
Comment Actions
- Implement Elvis' suggesions
- Use detected comp.method when adding files to existing archive
Comment Actions
We can test this and also check that the QComboBox contains the correct entries. However, I would rather do this in a separate diff since this one is already rather big.