krunner: polish placement
ClosedPublic

Authored by apol on Apr 12 2020, 10:15 PM.

Details

Summary

Tell the parent Dialog class what the location is so it can configure
the dialog accordingly.

Install the desktop file where it can be found by kwin to know about
X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.

While at it, make sure we don't leak if we return early.

Test Plan

Now I get the right animation

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 12 2020, 10:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2020, 10:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 12 2020, 10:15 PM
cblack accepted this revision.Apr 12 2020, 10:16 PM
This revision is now accepted and ready to land.Apr 12 2020, 10:16 PM

This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18, so I'll wait for @davidedmundson's comment.

apol updated this revision to Diff 80036.Apr 13 2020, 5:30 PM

DOn't set it to Dock type, all sort of bad things happen

davidedmundson accepted this revision.Apr 14 2020, 9:25 AM
This revision was automatically updated to reflect the committed changes.