Differential D2877

Use Plasma::PluginLoader to list applets
ClosedPublic
Actions

Authored by davidedmundson on Sep 27 2016, 9:07 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:a3b50ffff65d: Use Plasma::PluginLoader to list applets
R120:a3b50ffff65d: Use Plasma::PluginLoader to list applets
Summary

PluginLoader has some additional checks for some obscure config options,
such as ExcludeCategories in plasmashellrc.

By doing the applet listing manually widget explorer skipped that.

Test Plan

Checked widget explorer still listed everything

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6965.Sep 27 2016, 9:07 PM
davidedmundson retitled this revision from to Use Plasma::PluginLoader to list applets.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2016, 9:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Sep 27 2016, 10:12 PM
apol added inline comments.
components/shellprivate/widgetexplorer/widgetexplorer.cpp
135

shouldn't listAppletInfo be returning a QList<KPluginMetaData>?

davidedmundson added inline comments.Sep 27 2016, 10:19 PM
components/shellprivate/widgetexplorer/widgetexplorer.cpp
135

Yes. (especially as there's an added weirdness for some Plasma 5.3 compatibility where it loads the metadata again twice)

but it doesn't.... so that somewhat prevents me using it.

mart added a subscriber: mart.Sep 29 2016, 11:45 AM
mart added inline comments.
components/shellprivate/widgetexplorer/widgetexplorer.cpp
137

this shouldn't be necessary anymore as data should be a kplugininfo now?

mart accepted this revision.Oct 6 2016, 9:02 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 6 2016, 9:02 AM
Closed by commit R120:a3b50ffff65d: Use Plasma::PluginLoader to list applets (authored by davidedmundson). · Explain WhyOct 7 2016, 12:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7173

View Options

components/shellprivate/widgetexplorer/widgetexplorer.cpp

Loading...