Clean up deprecated calls and add missing overrides
ClosedPublic
Actions

Authored by ervin on Apr 11 2020, 1:56 PM.

Details

Reviewers

dfaure
bensi

Commits

Summary

This is warning spring cleaning time!

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin requested review of this revision.Apr 11 2020, 1:56 PM

ervin created this revision.

dfaure requested changes to this revision.Apr 11 2020, 2:08 PM

dfaure added inline comments.

src/akonadi/akonadimonitorimpl.cpp
44	This requires Qt 5.14. Which means: either add a #if QT_VERSION to call toSet() if Qt is older, or change set(REQUIRED_QT_VERSION 5.12.0) in CMakeLists.txt

This revision now requires changes to proceed.Apr 11 2020, 2:08 PM

OK, I can't seem to read properly today, I was pretty sure I read 5.10 and not 5.14 earlier...

Thanks dfaure.

This revision is now accepted and ready to land.Apr 11 2020, 2:39 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			3rdparty/kdepim/libkdepim/kdateedit.cpp (4 lines)
M			3rdparty/kdepim/libkdepim/kdatepickerpopup.cpp (4 lines)
M			src/akonadi/akonadimonitorimpl.cpp (17 lines)
M			src/akonadi/akonadistorage.cpp (17 lines)
M			src/widgets/itemdelegate.cpp (2 lines)
M			tests/units/testlib/akonadifakedatatest.cpp (21 lines)
M			tests/units/utils/compositejobtest.cpp (15 lines)
M			tests/units/utils/jobhandlertest.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79844	1ca089b		Apr 11 2020, 1:56 PM	★	★
Diff 2	79849	623cd3f	OK, I can't seem to read properly today, I was pretty sure I read 5.10 and not…	Apr 11 2020, 2:31 PM	★	★
Diff 3	79856	623cd3f	R4:836b113fb14962a0b1bd32bdcc3c70fd966a8fd2	Apr 11 2020, 2:31 PM	★	★