Make sure fetch jobs explicitly have a parent
ClosedPublic
Actions

Authored by ervin on Apr 11 2020, 12:27 PM.

Details

Reviewers

dfaure
bensi

Commits

R4:fd4eef976c33: Make sure fetch jobs explicitly have a parent

Summary

This prevents rogue job ending after a *Queries or *Repository object
has been deleted. The same type of work will have to be done for other
jobs, coming in separate commits.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin requested review of this revision.Apr 11 2020, 12:27 PM

ervin created this revision.

Harbormaster completed remote builds in B25058: Diff 79834.Apr 11 2020, 12:27 PM

dfaure accepted this revision.Apr 11 2020, 1:08 PM

This revision is now accepted and ready to land.Apr 11 2020, 1:08 PM

Closed by commit R4:fd4eef976c33: Make sure fetch jobs explicitly have a parent (authored by ervin). · Explain WhyApr 11 2020, 2:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/akonadi/akonadicachingstorage.h (4 lines)
M			src/akonadi/akonadicachingstorage.cpp (12 lines)
M			src/akonadi/akonadicontextqueries.h (3 lines)
M			src/akonadi/akonadicontextqueries.cpp (4 lines)
M			src/akonadi/akonadicontextrepository.cpp (6 lines)
M			src/akonadi/akonadidatasourcequeries.h (3 lines)
M			src/akonadi/akonadidatasourcequeries.cpp (2 lines)
M			src/akonadi/akonadilivequeryhelpers.h (10 lines)
M			src/akonadi/akonadilivequeryhelpers.cpp (34 lines)
M			src/akonadi/akonadiprojectqueries.h (3 lines)
M			src/akonadi/akonadiprojectqueries.cpp (4 lines)
M			src/akonadi/akonadiprojectrepository.cpp (8 lines)
M			src/akonadi/akonadistorage.h (4 lines)
M			src/akonadi/akonadistorage.cpp (8 lines)
M			src/akonadi/akonadistorageinterface.h (4 lines)
M			src/akonadi/akonaditaskqueries.cpp (14 lines)
M			src/akonadi/akonaditaskrepository.cpp (16 lines)
M			src/zanshin/migrator/zanshin021migrator.cpp (2 lines)
M			tests/testlib/akonadidebug.cpp (2 lines)
M			tests/testlib/akonadifakestorage.h (4 lines)
M			tests/testlib/akonadifakestorage.cpp (8 lines)
M			tests/testlib/akonadistoragetestbase.cpp (10 lines)
M			tests/testlib/fakejob.h (3 lines)
M			tests/testlib/fakejob.cpp (11 lines)
M			tests/units/akonadi/akonadicachingstoragetest.cpp (10 lines)
M			tests/units/akonadi/akonadicontextrepositorytest.cpp (42 lines)
M			tests/units/akonadi/akonadilivequeryhelperstest.cpp (8 lines)
M			tests/units/akonadi/akonadilivequeryintegratortest.cpp (8 lines)
M			tests/units/akonadi/akonadiprojectrepositorytest.cpp (34 lines)
M			tests/units/akonadi/akonaditaskqueriestest.cpp (14 lines)
M			tests/units/akonadi/akonaditaskrepositorytest.cpp (77 lines)