POP3: Remove the singleton pattern from Settings
ClosedPublic

Authored by dvratil on Apr 10 2020, 9:58 PM.

Details

Summary

It's causing issues with the "new" out-of-process settings
dialog which initializes a new Settings object each time and asserts
when the SettingsHelper Q_GLOBAL_STATIC is already initialized.

Instead just get rid of the singleton pattern and have Settings
object be owned by whomever created it and pass a reference to it
to the classes that need it.

BUG: 419726

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Apr 10 2020, 9:58 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 10 2020, 9:58 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Apr 10 2020, 9:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2020, 12:13 AM
This revision was automatically updated to reflect the committed changes.