Drop QWindow and explicit devicePixelRatio usage for ComboBox
ClosedPublic

Authored by broulik on Apr 10 2020, 4:04 PM.

Details

Summary

It's not done anywhere and breaks rendering the ComboBox on high dpi.

Test Plan

Would still like to know why this originally passed the window to it

Before


After

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 10 2020, 4:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 10 2020, 4:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 10 2020, 4:04 PM
davidre accepted this revision.Apr 10 2020, 4:04 PM
This revision is now accepted and ready to land.Apr 10 2020, 4:04 PM
davidedmundson accepted this revision.Apr 10 2020, 9:10 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kstyle/breezestyle.cpp
4474
    QPixmap Helper::coloredIcon(const QIcon& icon,  const QPalette& palette, const QSize &size, QIcon::Mode mode, QIcon::State state)
...
        const QPixmap pixmap = icon.pixmap(size, mode, state);

this takes a logical size, so this is indeed wrong.

This revision was automatically updated to reflect the committed changes.