Fix build
ClosedPublic

Authored by ngraham on Apr 10 2020, 3:22 PM.

Details

Reviewers
davidre
apol
Group Reviewers
Plasma
Commits
R135:6d7fe9e5a504: Fix build
Summary

Though for some reason it's not failing on the CI, plasma-integration is failing to build
for me with the following error:

/home/nate/kde/src/plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:342:78: error: cannot bind non-const lvalue reference of type ‘QStringList&’ to an rvalue of type ‘QStringList’
  342 |         dialog->m_fileWidget->setSupportedSchemes(options()->supportedSchemes());
      |                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

options()->supportedSchemes() returns a const reference but dialog->m_fileWidget->setSupportedSchemes
wants a non-const reference, so this patch has it make a local copy to keep it happy. This
is kind of weird since the code here hasn't been touched in years and
`options()->supportedSchemes() has returned a const reference for a long time too, yet
this code only now started failing for me yesterday.

Test Plan

It builds for me now

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 10 2020, 3:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 10 2020, 3:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 10 2020, 3:22 PM
apol accepted this revision.Apr 13 2020, 5:27 PM
apol added a subscriber: apol.

I don't really see why this would be necessary, but it's okay to add it.

This revision is now accepted and ready to land.Apr 13 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.