Redo api.kde.org to look more like Aether
ClosedPublic

Authored by cblack on Apr 9 2020, 8:58 PM.

Details

Diff Detail

Repository
R264 KApiDox
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 9 2020, 8:58 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptApr 9 2020, 8:58 PM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
cblack requested review of this revision.Apr 9 2020, 8:58 PM
ognarb added a comment.Apr 9 2020, 9:31 PM

Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar.

I also saw some alignment issues with the method args:

I will give a more in-depth review tomorrow.

ngraham added a subscriber: ngraham.Apr 9 2020, 9:49 PM

Dang that looks way nicer.

Nice work. This is a ship it for me!

ochurlaud accepted this revision.Apr 9 2020, 10:01 PM
This revision is now accepted and ready to land.Apr 9 2020, 10:01 PM

Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar.

I also saw some alignment issues with the method args:

I will give a more in-depth review tomorrow.

The issues already exist in the current design. I would do a second change request for fixing those issues (there are more if you browse a little in complex methods) and already push this cosmetic only patch.

ognarb accepted this revision.Apr 10 2020, 11:47 AM

LGTM

This revision was automatically updated to reflect the committed changes.