Differential D28710

Make accidental panel and panel widget deletion more difficult
ClosedPublic
Actions

Authored by ngraham on Apr 9 2020, 7:29 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Maniphest Tasks
T12942: Refine how global edit mode relates to panel edit mode and the previous widget locking feature
Commits
R119:4b87247fa39b: Merge branch 'Plasma/5.18'
R119:ba66d2eabe38: Make accidental panel and panel widget deletion more difficult
Summary

We make it very easy to delete panels and panel widgets--perhaps a bit too easy. User
feedback has indicated that we may need to re-work this a bit, and that perhaps D20144 was a
mistake.

This patch moves the Remove Panel button back into the More menu where it used to
be, to make it harder to accidentally click on. It also moves the Remove button for
panel widgets higher up in the menu so it's not so close to the cursor.

To adjust to these changes, the layout of buttons on the panel toolbar is changed to
preserve visual balance, and the More menu's name is adjusted to reflect the fact that
removing a panel is not a setting.

BUG: 419853
FIXED-IN: 5.18.5

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 9 2020, 7:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2020, 7:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 9 2020, 7:29 PM
ngraham updated this revision to Diff 79739.Apr 9 2020, 9:45 PM
ngraham added a subscriber: broulik.

Fix the FIXMEs (thanks for the help @broulik)

ngraham retitled this revision from [RFC] Make accidental panel and panel widget deletion more difficult to Make accidental panel and panel widget deletion more difficult.Apr 9 2020, 9:45 PM
ngraham edited the summary of this revision. (Show Details)
ngraham updated this revision to Diff 79950.Apr 12 2020, 6:19 PM
  • Also reposition the Remove Panel button pased on panel orientation
  • Ditch the overcomplicated loaders and components
ngraham updated this revision to Diff 79953.Apr 12 2020, 6:21 PM

Correct the patch base (stupid arc)

ngraham added a comment.Apr 13 2020, 2:51 PM

Since this doesn't add any new strings, it could potentially be considered a bugfix and make it into a 5.18 bugfix release.

ndavis accepted this revision.Apr 13 2020, 4:50 PM
This revision is now accepted and ready to land.Apr 13 2020, 4:50 PM
ngraham updated this revision to Diff 80032.Apr 13 2020, 5:03 PM

Revert string change so it can be landed on the stable branch

ngraham edited the summary of this revision. (Show Details)Apr 13 2020, 5:04 PM
davidedmundson added a subscriber: davidedmundson.Apr 13 2020, 5:11 PM

We shouldn't be making UX changes on the stable branch

Closed by commit R119:ba66d2eabe38: Make accidental panel and panel widget deletion more difficult (authored by ngraham). · Explain WhyApr 13 2020, 5:12 PM
This revision was automatically updated to reflect the committed changes.
rikmills added a comment.EditedApr 16 2020, 11:10 AM
In D28710#647340, @davidedmundson wrote:

We shouldn't be making UX changes on the stable branch

I agree. This could make getting the 5.18.5 release accepted as a K/Ubuntu stable release update (SRU) difficult (or rejected) in a few weeks time.

mart added a subscriber: mart.Apr 20 2020, 11:17 AM

I reverted this change in the 5.18 branch, as there shouldn't ever be ui changes in stable branches (unless very, very serious)

this change is still valid for master/5.19

ngraham added a comment.Apr 20 2020, 1:04 PM

Oh gosh, I'm sorry. I didn't mean to to that. :/ Thanks for correcting my mistake!

Revision Contents
Changeset List

Diff 80033

View Options

containments/panel/contents/ui/ConfigOverlay.qml

Loading...
View Options

desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml

Loading...
View Options

desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

Loading...