Show purpose context menu only when enabled
ClosedPublic

Authored by broulik on Apr 9 2020, 4:58 PM.

Details

Summary

Check whether the extension is supported and enabled.
Unfortunately, I removed the loaded/unloaded singals for plugins in the host at some point and so I don't have convenient signals for that anymore :(
I will add them back but for stable and older hosts that won't really help.

BUG: 418436

Test Plan
  • Started p-b-i, got Share entry, disabled in settings, Share entry was gone, turned it back on, Share entry reappeared
  • Patched my host to not have purpose plugin (simulating older plasma), got no share entry

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 9 2020, 4:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2020, 4:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 9 2020, 4:58 PM
broulik edited the summary of this revision. (Show Details)Apr 9 2020, 5:02 PM
broulik updated this revision to Diff 80149.Apr 14 2020, 6:49 PM
  • Remove caching

We update the menu on startup and when settings change, no need to cache it.

broulik updated this revision to Diff 80177.Apr 15 2020, 8:43 AM
  • Call updatePurposeMenu() on connect
fvogt accepted this revision.Apr 15 2020, 8:47 AM
This revision is now accepted and ready to land.Apr 15 2020, 8:47 AM
This revision was automatically updated to reflect the committed changes.