Make KAccess a regular startup application
ClosedPublic

Authored by broulik on Apr 9 2020, 2:15 PM.

Details

Summary

Also ports it away from KToolInvocation.
I don't really see why it would have to start that early in the process?

Test Plan
  • Enabled screen reader, logged in, plasmashell would still talk to the screen reader

Imho using QProcess to restart it on save is fine since user clicking Save expecting to reload the settings and it's a background process anyway, so no need to bouncy cursor

Some feedback from people more knowledgable in Accessibility would be appreciated :)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 9 2020, 2:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2020, 2:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 9 2020, 2:15 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)Apr 9 2020, 2:19 PM
davidedmundson accepted this revision.Apr 9 2020, 3:47 PM
davidedmundson added a subscriber: davidedmundson.

Please double check wayland startup is ok. The kcminit had a X-KDE-OnlyShowOnQtPlatforms=xcb; guard

Orca situation should be fine

/home/david/projects/qt5/qtbase/src/platformsupport/linuxaccessibility/dbusconnection.cpp:    dbusWatcher = new QDBusServiceWatcher(A11Y_SERVICE, c, QDBusServiceWatcher::WatchForRegistration, this);
This revision is now accepted and ready to land.Apr 9 2020, 3:47 PM

Autostart doesn't appear to respect that property and I don't think we just want to check KService::noDisplay() *but* kaccess appears to launch and even screen reader works.

This revision was automatically updated to reflect the committed changes.