Differential D28691

[kded] Clean up notification handling
ClosedPublic
Actions

Authored by nicolasfella on Apr 8 2020, 10:20 PM.

Details

Reviewers
jgrulich
broulik
Group Reviewers
Plasma
Commits
R116:0eeb2605df8e: [kded] Clean up notification handling
Summary

Remove calls to deleteLater(), KNotification objects delete themselves after they timed out.
Remove unnecessary parent assignments.
Remove unnecessary id check before storing, this was introduced in a19794a3e as a supposed crash fix, but I doubt it actually fixes anything.

Test Plan

Spawned some connection (de)activated and error notifications

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 8 2020, 10:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2020, 10:20 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 8 2020, 10:20 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 8 2020, 10:24 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added reviewers: Plasma, broulik.
nicolasfella updated this revision to Diff 79676.Apr 8 2020, 10:37 PM
nicolasfella edited the summary of this revision. (Show Details)
  • Fix
jgrulich accepted this revision.Apr 9 2020, 5:37 AM
This revision is now accepted and ready to land.Apr 9 2020, 5:37 AM
Closed by commit R116:0eeb2605df8e: [kded] Clean up notification handling (authored by nicolasfella). · Explain WhyApr 9 2020, 12:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/notification.cpp (28 lines)

Diff 79694

View Options

kded/notification.cpp

Loading...