Differential D28686

[Battery Monitor] Choose better wording
AbandonedPublic
Actions

Authored by shubham on Apr 8 2020, 6:42 PM.

Details

Reviewers
ngraham
ognarb
Group Reviewers
VDG
Test Plan
  1. Compile
  2. Source prefix.sh
  3. plasmashell --replace

Diff Detail

Repository
R120 Plasma Workspace
Branch
fix-wording
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24957
Build 24975: arc lint + arc unit
shubham created this revision.Apr 8 2020, 6:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2020, 6:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
shubham requested review of this revision.Apr 8 2020, 6:42 PM
shubham added reviewers: broulik, VDG, ngraham.Apr 8 2020, 6:43 PM
shubham edited the test plan for this revision. (Show Details)
broulik added a comment.Apr 9 2020, 7:10 AM

"Life remaining" sounds as if it blows up any minute. Perhaps "Remaining time"?

shubham updated this revision to Diff 79686.Apr 9 2020, 8:08 AM
ngraham accepted this revision.Apr 9 2020, 4:40 PM
ngraham added 1 blocking reviewer(s): broulik.

LGTM. @broulik?

ognarb accepted this revision.Jul 16 2020, 5:35 PM
ognarb added a subscriber: ognarb.

Change makes sense to me, IIRC Kai doesn't have much time for KDE anymore

ngraham removed a reviewer: broulik.Jul 16 2020, 6:16 PM

Go ahead and land this.

This revision is now accepted and ready to land.Jul 16 2020, 6:16 PM

Revision Contents
Changeset List

Diff 79662

View Options

applets/batterymonitor/package/contents/ui/logic.js

Loading...