To avoid having to lock and unlock the mutex everywhere (and ensure it is unlocked before calling other things that might lock it, etc.), do it as locally as possible.
BUG: 419585
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:35b4c6d4df12: Fix crashing on starting and quitting
Doesn't crash all the time anymore, and doesn't randomly hang like when I tried to lock and unlock it "manually" everywhere.
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Can't reproduce the crash, but this looks reasonable to me.
Please push to release/20.04.
Comment Actions
Sorry, holidays.
But yeah, it seems to only crash with a newer dolphin and icu, and seems to be very threading-dependent and hard to reproduce. But locking this should be the right thing to do anyways.
Comment Actions
Feel free to just push on behalf of me in the future, though, work and holidays often get in the way of quickly following up on stuff..