Differential D28658

[krdb] Drop GTK2 colour exporting
ClosedPublic
Actions

Authored by cblack on Apr 7 2020, 2:17 PM.

Details

Reviewers
ngraham
davidedmundson
gikari
Group Reviewers
Plasma
Commits
R119:2fb0bf85fe63: [krdb] Drop GTK2 colour exporting
Summary

With the vast supermajority of modern GTK2 themes using pixmaps, exporting colours
is only likely to result in breakage.

BUG: 412331
FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Apr 7 2020, 2:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2020, 2:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 7 2020, 2:17 PM
ngraham added a subscriber: ngraham.Apr 7 2020, 2:19 PM

Probably needs some inline documentation here (as well as in the header file) that the exportColors arg now is does a no-op. Or can we even remove it entirely?

ngraham edited the summary of this revision. (Show Details)Apr 7 2020, 2:21 PM
fvogt added a subscriber: fvogt.Apr 7 2020, 2:32 PM
cblack updated this revision to Diff 79579.Apr 7 2020, 2:33 PM

Drop the exportColors argument

ngraham accepted this revision.Apr 7 2020, 7:04 PM
ngraham added reviewers: gikari, davidedmundson. ngraham added 1 blocking reviewer(s): Plasma.
ngraham added a subscriber: gikari.

Conceptually this makes sense, and the support for this doesn't really work anymore and is in fact causing 412331 (the bug got introduced when this code started working again when recoloration support went in).

Let's make sure @gikari and the Plasma folks are okay with this though.

gikari added a comment.Apr 7 2020, 9:15 PM

We also need to remove the remaining GTK stuff from here once D28070 and D28072 are landed. Does anyone else wants to test the later?

kcms/krdb/krdb.cpp
377

Is this somewhat relevant to GTK?

cblack added inline comments.Apr 10 2020, 7:05 PM
kcms/krdb/krdb.cpp
377

Pretty sure it's writing the xrdb there.

gikari resigned from this revision.Apr 11 2020, 9:56 AM

No objections from me.

davidedmundson accepted this revision.Apr 14 2020, 10:54 AM
This revision is now accepted and ready to land.Apr 14 2020, 10:54 AM
Closed by commit R119:2fb0bf85fe63: [krdb] Drop GTK2 colour exporting (authored by cblack). · Explain WhyApr 17 2020, 3:45 PM
This revision was automatically updated to reflect the committed changes.
fvogt added a comment.Apr 24 2020, 1:24 PM

FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?)

At least in openSUSE we'll backport it to Plasma 5.18, but it might not be the kind of behaviour change desired in 5.18 at this point in time...

Revision Contents
Changeset List

PathPackages
Mkcms/krdb/krdb.cpp (66 lines)

Diff 80406

View Options

kcms/krdb/krdb.cpp

Loading...