[Notifications] Report roleNames in the relevant places
ClosedPublic

Authored by broulik on Apr 7 2020, 1:56 PM.

Details

Summary

QML needs it on the model it uses (Notifications) where they used to be but GammaRay seems to be taking them from the source (NotificationsModel).
This has both models (and jobs model) return the roleNames() and moves them to Utils so they're shared.

Test Plan
  • Notifications still work
  • Inspecting the models with GammaRay has proper role names now.

I kinda would have expected the rolenames from notificationsmodel to bubble down to us but maybe qml asks for them before we have initialized the models

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 7 2020, 1:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2020, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 7 2020, 1:56 PM
davidedmundson accepted this revision.Apr 14 2020, 10:39 AM
This revision is now accepted and ready to land.Apr 14 2020, 10:39 AM
This revision was automatically updated to reflect the committed changes.