[Notifications] Don't reverse() Array
ClosedPublic

Authored by broulik on Apr 7 2020, 12:50 PM.

Details

Summary

This mutates the source array.
In practice actions don't really change in existing notifications but still better to not do that.

Test Plan

5.18?
Did some grouping popups thing and my buttons don't randomly shuffle anymore
Maybe that could also have been the cause for the kde connect buttons being swapped? Though I think that's not on our side.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 7 2020, 12:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2020, 12:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 7 2020, 12:50 PM
davidedmundson accepted this revision.Apr 14 2020, 10:38 AM
This revision is now accepted and ready to land.Apr 14 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.