Initial port of web plugin to Qt5/KReport3/QtWebEngine
ClosedPublic

Authored by piggz on Sep 26 2016, 9:49 PM.

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
piggz updated this revision to Diff 6935.Sep 26 2016, 9:49 PM
piggz retitled this revision from to Initial port of web plugin to Qt5/KReport3/QtWebEngine.
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptSep 26 2016, 9:49 PM
piggz updated this revision to Diff 6963.Sep 27 2016, 7:34 PM
  • Switch back to QtWebKit
staniek accepted this revision.Sep 27 2016, 11:01 PM
staniek edited edge metadata.

Minor note only. Cool job!

PS: Please don't forget to include D2863 and T3565 in the commit message.

src/plugins/web/KReportWebPlugin.cpp
31–32

I think we can remove this code?

This revision is now accepted and ready to land.Sep 27 2016, 11:02 PM
This revision was automatically updated to reflect the committed changes.