Use ecm_setup_qtplugin_macro_names
AbandonedPublic

Authored by kossebau on Apr 6 2020, 11:19 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Summary

Avoids all the explicit boilerplate needed, ensures the dependency on
the JSON file ia also set and allows simple export of the setup
in the installed CMake config file, so other projects importing
the config file have the respective CMake macros set as recommended.

Test Plan

Still builds as before. Touch of a plugin metadata JSON file now triggers a
moc rerun. CMake config file contains setup of variables.

Diff Detail

Repository
R223 Okular
Branch
useECMSetupQtPluginMacroNames
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24889
Build 24907: arc lint + arc unit
kossebau created this revision.Apr 6 2020, 11:19 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 6 2020, 11:19 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 6 2020, 11:19 PM
kossebau edited the test plan for this revision. (Show Details)Apr 6 2020, 11:22 PM
aacid requested changes to this revision.Apr 7 2020, 9:36 PM
aacid added a subscriber: aacid.

Please use invent.kde.org for patches so we get the pre-commit CI

This revision now requires changes to proceed.Apr 7 2020, 9:36 PM