Differential D28638

Port away from KIconLoader::loadMimeTypeIcon
ClosedPublic
Actions

Authored by nicolasfella on Apr 6 2020, 11:01 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Commits
R94:d5ff89a1b97d: Port away from KIconLoader::loadMimeTypeIcon
Summary

It does not do much special, except for having a fallback for when no mimetype icon is available.

Test Plan

Viewed attachment properties for file with/without mime type icons

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 6 2020, 11:01 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2020, 11:01 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
nicolasfella requested review of this revision.Apr 6 2020, 11:01 PM
vkrause accepted this revision.Apr 7 2020, 8:47 AM
vkrause added a subscriber: vkrause.

This should even allow removing the entire dependency on KIconThemes in this library I think.

This revision is now accepted and ready to land.Apr 7 2020, 8:47 AM
Closed by commit R94:d5ff89a1b97d: Port away from KIconLoader::loadMimeTypeIcon (authored by nicolasfella). · Explain WhyApr 7 2020, 10:03 AM
This revision was automatically updated to reflect the committed changes.
nicolasfella added a comment.Apr 7 2020, 10:04 AM
In D28638#643435, @vkrause wrote:

This should even allow removing the entire dependency on KIconThemes in this library I think.

Nope, there's still quite some KIconLoader usage left

vkrause added a comment.Apr 7 2020, 12:05 PM
In D28638#643459, @nicolasfella wrote:
In D28638#643435, @vkrause wrote:

This should even allow removing the entire dependency on KIconThemes in this library I think.

Nope, there's still quite some KIconLoader usage left

in all of messagelib, yes, but not in messagecore

Revision Contents
Changeset List

Diff 79559

View Options

messagecore/src/attachment/attachmentpropertiesdialog.cpp

Loading...