[resources] Use "/" instead of QDir::separator
ClosedPublic
Actions

Authored by poboiko on Apr 6 2020, 6:59 PM.

Details

Reviewers

dvratil
mlaurent

Commits

Summary

As Qt documentation states (https://doc.qt.io/qt-5/qdir.html#separator),
QDir::separator() should not be used to build file paths.

Note to reviewers: I might have confused QStringLiteral vs QLatin1String vs QLatin1Char
in some places, please correct me if I'm wrong

Test Plan

It compiles

Repository

R44 KDE PIM Runtime

Branch

maildir-qdir-separator (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24954
Build 24972: arc lint + arc unit

poboiko requested review of this revision.Apr 6 2020, 6:59 PM

mlaurent requested changes to this revision.Apr 7 2020, 4:51 AM

mlaurent added inline comments.

resources/shared/singlefileresource/singlefileresourcebase.cpp
242	Why replacing QLatin1Char(..) by QStringLiteral("..") ?
resources/vcarddir/vcarddirresource.cpp
251	Use QLatin1Char('/') everywhere

This revision now requires changes to proceed.Apr 7 2020, 4:51 AM

Use QLatin1Char

mlaurent requested changes to this revision.Apr 8 2020, 4:46 AM

mlaurent added inline comments.

resources/shared/singlefileresource/singlefileresourcebase.cpp
242	QLatin1Char('-') not QStringLiteral("-")

This revision now requires changes to proceed.Apr 8 2020, 4:46 AM

Changed yet another QStringLiteral(char) -> QLatin1Char.

Missed that one, sorry.

This revision is now accepted and ready to land.Apr 9 2020, 4:41 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			resources/contacts/contactsresource.cpp (28 lines)
M			resources/icaldir/icaldirresource.cpp (4 lines)
M			resources/kalarm/kalarmdir/kalarmdirresource.cpp (4 lines)
M			resources/maildir/libmaildir/maildir.cpp (6 lines)
M			resources/maildir/maildirresource.cpp (8 lines)
M			resources/mixedmaildir/mixedmaildirstore.cpp (4 lines)
M			resources/shared/singlefileresource/singlefileresourcebase.cpp (2 lines)
M			resources/vcarddir/vcarddirresource.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79523	fa8b752		Apr 6 2020, 6:59 PM	★	★
Diff 2	79578	fa8b752	Use `QLatin1Char`	Apr 7 2020, 2:25 PM	★	★
Diff 3	79659	fa8b752	Changed yet another `QStringLiteral(char) -> QLatin1Char`.	Apr 8 2020, 5:46 PM	★	★
Diff 4	79692	2b3664e	R44:a2018f67c67c3c0ec9b8dcfb18be580bd29ac7c6	Apr 9 2020, 10:15 AM	★	★