Instead, have KSMServer talk to us directly on DBus.
This allows us to start KWin independently of a session manager, for example in case of systemd, or whenever there will be a Wayland session restore protocol.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:be31101f127b: Remove QSessionManager usage
R108:59642a4b2814: Merge branch 'broulik/no_ksmserver'
Depends on D28616
- KWin still restores window properties (such as opacity) on restored apps on startup
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1 LGTM
sm.cpp | ||
---|---|---|
357 | Care to elaborate? what do you have in mind here? Feels like it could end up being one of these TODO that stay forever |
sm.cpp | ||
---|---|---|
357 | Ack, I rarely see a TODO and act upon it in any meaningful way. IMHO it's not a problem as-is. One is a request for kwin to perform an action, the other is a property of the state the whole session should be in. It allows us to be more explicit that we're shutting down or whatever which could outlive session management operations and to separate ksmserver specific code further. |