Increase minimum ECM version, required by File Size View
ClosedPublic

Authored by marten on Apr 5 2020, 3:21 PM.

Details

Summary

The File Size View plugin now uses ecm_qt_declare_logging_category with the EXPORT and DESCRIPTION parameters, which are only supported since ECM 5.68.0

Test Plan

Builds while expecting that ECM version:

  • The following REQUIRED packages have been found:
  • ECM (required version >= 5.68.0)

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten requested review of this revision.Apr 5 2020, 3:21 PM
marten created this revision.
dfaure requested changes to this revision.Apr 5 2020, 3:23 PM

Please remove or adapt the comment. 5.38 was about the new layout (bin/ dir etc.). 5.68 is about "ecm_qt_declare_logging_category with the EXPORT and DESCRIPTION parameters". Or remove the comment and let people use git log if they're curious about the min req ;)

This revision now requires changes to proceed.Apr 5 2020, 3:23 PM
marten updated this revision to Diff 79417.Apr 5 2020, 3:27 PM

Removed obsolete/misleading comment

dfaure accepted this revision.Apr 5 2020, 3:37 PM
This revision is now accepted and ready to land.Apr 5 2020, 3:37 PM
This revision was automatically updated to reflect the committed changes.