Differential D28591

Add #ifndef QT_NO_SYSTEMTRAYICON to KleopatraApplication::~Private()
ClosedPublic
Actions

Authored by andreylegayev on Apr 5 2020, 12:52 PM.

Details

Reviewers
mlaurent
Commits
R168:f8efa6b74af6: Patch from Andrey Legayev
Summary

I've found that class member sysTray is not created if QT_NO_SYSTEMTRAYICON defined: see it in kleopatraapplication.cpp line 148
I've added the same pre-processing macros for delete statement to prevent compilation error.

Test Plan

Try to compile with QT_NO_SYSTEMTRAYICON - it should proceed without errors.

Diff Detail

Repository
R168 Kleopatra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreylegayev created this revision.Apr 5 2020, 12:52 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 5 2020, 12:52 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
andreylegayev requested review of this revision.Apr 5 2020, 12:52 PM
mlaurent accepted this revision.Apr 5 2020, 2:28 PM
This revision is now accepted and ready to land.Apr 5 2020, 2:28 PM
andreylegayev added a comment.Apr 5 2020, 3:42 PM

@mlaurent I don't have dev-access. Could you merge it?

mlaurent added a comment.Apr 5 2020, 4:48 PM

Ok I will do tomorrow morning
Thanks

Closed by commit R168:f8efa6b74af6: Patch from Andrey Legayev (authored by mlaurent). · Explain WhyApr 9 2020, 5:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kleopatraapplication.cpp (2 lines)

Diff 79683

View Options

src/kleopatraapplication.cpp

Loading...