Differential D28589

Dolphin: port to CommandLauncherJob
ClosedPublic
Actions

Authored by dfaure on Apr 5 2020, 11:45 AM.

Details

Reviewers
broulik
elvisangelaccio
meven
Commits
R318:40035fe5bf4d: Dolphin: port to CommandLauncherJob
Summary

git master already requires 5.69 anyway, due to KBookmarkMenu API change

Test Plan

Builds, Tools / Compare Files works.

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24794
Build 24812: arc lint + arc unit
dfaure created this revision.Apr 5 2020, 11:45 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 5 2020, 11:45 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 5 2020, 11:45 AM
meven accepted this revision.Apr 5 2020, 5:06 PM
This revision is now accepted and ready to land.Apr 5 2020, 5:06 PM
elvisangelaccio accepted this revision.Apr 5 2020, 6:21 PM
elvisangelaccio added inline comments.
CMakeLists.txt
11

Sorry, I just pushed this with a different commit.

dfaure closed this revision.Apr 5 2020, 6:33 PM
dfaure added inline comments.Apr 5 2020, 6:33 PM
CMakeLists.txt
11

No problem, git rebases just fine ;)

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/dolphinmainwindow.cpp (6 lines)
Msrc/dolphintabwidget.cpp (7 lines)

Diff 79395

View Options

CMakeLists.txt

Loading...
View Options

src/dolphinmainwindow.cpp

Loading...
View Options

src/dolphintabwidget.cpp

Loading...