akregator: port away from ReadOnlyPart.
ClosedPublic

Authored by dfaure on Apr 5 2020, 9:05 AM.

Details

Summary

This removes the konqueror integration which didn't really work anyway
(RMB on .rss file / Preview In / Akregator -> akregrator would be
embedded but wouldn't add this feed). RMB / Add to Akregator is simpler
and works better anyway.

This will allow us to load kontact plugins without desktop files
(using json) in the future.

Depends on D28581.

Test Plan

akregator still works (standalone and in kontact) and I was able to add a new feed
in the GUI (and the icon worked btw, also after a restart).

Diff Detail

Repository
R201 Akregator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Apr 5 2020, 9:05 AM
dfaure created this revision.
mlaurent added inline comments.Apr 5 2020, 10:32 AM
src/frame/webengine/webengineframe.h
26

I don't see why you added it ?

dfaure added inline comments.Apr 5 2020, 10:49 AM
src/frame/webengine/webengineframe.h
26

To fix compilation ;)

I guess it came via kparts/browserextension.h

mlaurent accepted this revision.Apr 5 2020, 11:01 AM

Ah ok :)

This revision is now accepted and ready to land.Apr 5 2020, 11:01 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 5 2020, 11:08 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript