Akregator: fix URL/path confusion which led to KIO warnings and possibly missing icons
ClosedPublic
Actions

Authored by dfaure on Apr 5 2020, 8:15 AM.

Details

Reviewers

mlaurent

Commits

Summary

The faviconUrl stored in ~/.local/share/akregator/data was a path rather
than a URL.

It's also pretty pointless to then do a download job on that local file...

Test Plan

I've been having some trouble finding RSS sites with icons...
Please double-check.

Repository

R201 Akregator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Apr 5 2020, 8:15 AM

dfaure created this revision.

it seems ok for me.

This revision is now accepted and ready to land.Apr 5 2020, 10:12 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

			Path	Packages
M			src/feed/feed.h (2 lines)
M			src/feed/feed.cpp (31 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79374	4ca5f7c		Apr 5 2020, 8:15 AM	★	★
Diff 2	79388	a7d3699	R201:7494996c9de81ced6ea74b96978d5e1862a311c5	Apr 5 2020, 10:10 AM	★	★