Use KRun for "Open with"->"Other..." dialog
AbandonedPublic

Authored by abika on Sep 26 2016, 4:51 PM.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika updated this revision to Diff 6925.Sep 26 2016, 4:51 PM
abika retitled this revision from to Use KRun for "Open with"->"Other..." dialog.
abika added a reviewer: Krusader.
Closed by commit R167:d5c70dfbe0d3: Use KRun for "Open with"->"Other..." dialog (authored by Alexander Bikadorov <bikaejkb@mailbox.tu-berlin.de>). · Explain WhySep 26 2016, 4:53 PM
This revision was automatically updated to reflect the committed changes.
janlepper reopened this revision.Jan 13 2017, 4:40 PM
janlepper added a subscriber: janlepper.

I intentionally went via ListPanelFunc::runCommand() so that the panel's path is set as working directory for the command.
With KRun::displayOpenWithDialog() there is no guarantee for that.

See also T5057

janlepper requested changes to this revision.Jan 18 2017, 4:38 AM
janlepper added a reviewer: janlepper.
This revision now requires changes to proceed.Jan 18 2017, 4:38 AM
abika added a comment.Feb 10 2017, 6:03 PM

I see. Is the working directory really important for (any) application? It seems strange that Krusader does this different compared to e.g. Dolphin.

Should I revert it (+ a comment why KRun::displayOpenWithDialog is not used here)?

asensi added a subscriber: asensi.Feb 11 2017, 2:36 PM

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

abika abandoned this revision.Feb 15 2017, 6:08 PM
In D2857#85422, @asensi wrote:

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

Fair enough. I reverted it.

BTW: what is the reason for dialog.hideRunInTerminal();?

In D2857#86585, @abika wrote:
In D2857#85422, @asensi wrote:

Is the working directory really important for (any) application?

I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.

Fair enough. I reverted it.

BTW: what is the reason for dialog.hideRunInTerminal();?

I don't remember - just tested it without that, and running in terminal works.
Maybe it didn't in KDE4.
So I suggest we remove that line.