Details
- Reviewers
janlepper - Group Reviewers
Krusader - Commits
- R167:d5c70dfbe0d3: Use KRun for "Open with"->"Other..." dialog
Diff Detail
- Repository
- R167 Krusader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
I intentionally went via ListPanelFunc::runCommand() so that the panel's path is set as working directory for the command.
With KRun::displayOpenWithDialog() there is no guarantee for that.
See also T5057
I see. Is the working directory really important for (any) application? It seems strange that Krusader does this different compared to e.g. Dolphin.
Should I revert it (+ a comment why KRun::displayOpenWithDialog is not used here)?
Is the working directory really important for (any) application?
I don't recall using any, although probably some exist, and if ListPanelFunc::runCommand() works and allows that those application work correctly, probably it would be better for Krusader to use that code.
I don't remember - just tested it without that, and running in terminal works.
Maybe it didn't in KDE4.
So I suggest we remove that line.