Differential D28557

IncidenceEditor: pass ETM to CollectionCombobox, if it was set
ClosedPublic
Actions

Authored by dfaure on Apr 4 2020, 1:17 PM.

Details

Reviewers
vkrause
mlaurent
winterz
Commits
R78:905fda174708: IncidenceEditor: pass ETM to CollectionCombobox, if it was set
Summary

If it's nullptr, then CollectionCombobox will create an ETM internally,
juts like before.

Depends on D28556

Test Plan

incidence dialog is much faster

Diff Detail

Repository
R78 PIM: Incidence Editor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24728
Build 24746: arc lint + arc unit
dfaure created this revision.Apr 4 2020, 1:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 4 2020, 1:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure requested review of this revision.Apr 4 2020, 1:17 PM
dfaure updated this revision to Diff 79294.Apr 4 2020, 1:47 PM

Add explicit dependency on akonadi-calendar, which provides us with IncidenceChanger

mlaurent accepted this revision.Apr 4 2020, 2:06 PM
This revision is now accepted and ready to land.Apr 4 2020, 2:06 PM
dfaure closed this revision.Apr 4 2020, 7:44 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/incidencedialog.cpp (3 lines)

Diff 79294

View Options

CMakeLists.txt

Loading...
View Options

src/incidencedialog.cpp

Loading...