Rename stylesheet color ButtonFocus -> Highlight
AbandonedPublic

Authored by davidhurka on Apr 4 2020, 10:24 AM.

Details

Reviewers
ndavis
Summary

This fixes the 3 icons with blue elements, which I recently modified. I used ButtonFocus, but it should be Highlight.

Diff Detail

Repository
R266 Breeze Icons
Branch
rename-buttonfocus-highlight
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24710
Build 24728: arc lint + arc unit
davidhurka created this revision.Apr 4 2020, 10:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 4 2020, 10:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidhurka requested review of this revision.Apr 4 2020, 10:24 AM
ndavis added a comment.EditedApr 4 2020, 11:53 AM

Actually, I just tested the icons in Cuttlefish and apparently ButtonFocus works now, so it's preferred over Highlight. Sorry to give you the run around.

Cuttlefish (Ubuntu release)?

So that means all icons should be changed from Highlight to ButtonFocus? That would also affect colorful icons. Some of them have Highlight and ButtonFocus in the stylesheet, fortunately with the same color.

ndavis added a comment.EditedApr 4 2020, 12:25 PM

Cuttlefish (Ubuntu release)?

So that means all icons should be changed from Highlight to ButtonFocus? That would also affect colorful icons. Some of them have Highlight and ButtonFocus in the stylesheet, fortunately with the same color.

Don't worry about it. I'll do a pass once KF5.69 is tagged.

There may be some cases where it's still preferrable to use Highlight, but most icons should use ButtonFocus.

davidhurka abandoned this revision.Apr 4 2020, 12:48 PM

Ok, then I’ll let you do it.

ndavis added a comment.EditedApr 5 2020, 8:13 PM

@davidhurka Actually, I'm using Highlight. I still can't get ButtonFocus to work reliably and Highlight in icons now changes to white when a UI element gets highlighted, which is good. I just pushed a patch to convert ButtonFocus to Highlight.

BTW, join the VDG chat if you haven't already.